Enhance plot_pdp and fix plot_scatter_submodels
#218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexAndorra
added
bug
aloctavodia
requested changes
Feb 17, 2025
aloctavodia
reviewed
Feb 18, 2025
|
Thanks for the ping amigo! I didn't forget, I'm just swamped right now, but
will push the change ASAP
El El vie, 7 mar 2025 a la(s) 3:40, Osvaldo A Martin <
***@***.***> escribió:
… ***@***.**** commented on this pull request.
------------------------------
In pymc_bart/utils.py
<#218 (comment)>:
> @@ -396,11 +396,18 @@ def identity(x):
p_d = _sample_posterior(
all_trees, X=fake_X, rng=rng, size=samples, excluded=excluded, shape=shape
)
+ # need to apply func to full array and to last dimension if it's softmax
+ if func.__name__ == "softmax":
@AlexAndorra <https://github.com/AlexAndorra>
—
Reply to this email directly, view it on GitHub
<#218 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHIJMTG3TLOPJJZINE3BT2D2TFLODAVCNFSM6AAAAABXICSTZ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNRWGU4TMNJZGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I just added the change to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
softmax_linkoption toplot_pdpfor the Categorical likelihood caseplot_scatter_submodelsto be able to handle the categorical likelihood case